Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Angular: bump zone.js version in peer dependencies #8558

Merged
merged 1 commit into from
Oct 25, 2019
Merged

Angular: bump zone.js version in peer dependencies #8558

merged 1 commit into from
Oct 25, 2019

Conversation

sharikovvladislav
Copy link

@sharikovvladislav sharikovvladislav commented Oct 24, 2019 •
edited
Loading

Issue:
When you install @storybook/angular and you have zone.js@0.10.x as dependency you will get the following warning in the console:

 @storybook/angular@5.3.0-alpha.19 requires a peer of zone.js@^0.8.29 || ^0.9.0 but none is installed. You must install peer dependencies yourself

What I did

Updated zone.js in peerDependencies in Angular

@vercel
Copy link

vercel bot commented Oct 24, 2019 •
edited
Loading

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/kqqjr5oui
🌍 Preview: https://monorepo-git-fork-sharikovvladislav-next.storybook.now.sh

shilman
shilman approved these changes Oct 24, 2019
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shilman shilman added this to the 5.3.0 milestone Oct 24, 2019
@sharikovvladislav
Copy link
Author

What should I do with https://github.com/storybookjs/storybook/pull/8558/checks?check_run_id=273589229?

@shilman shilman changed the title chore(*): bump zone.js version in peer dependencies Angular: bump zone.js version in peer dependencies Oct 25, 2019
@shilman shilman merged commit 16accd2 into storybookjs:next Oct 25, 2019
This was referenced Aug 11, 2020
Closed
Closed
Closed
Closed
This was referenced Oct 20, 2020
Closed
Closed
This was referenced Aug 28, 2021
Closed
Closed
Closed
@snyk-bot snyk-bot mentioned this pull request Sep 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@alterx alterx Awaiting requested review from alterx

@igor-dv igor-dv Awaiting requested review from igor-dv

Assignees
No one assigned
Labels
angular dependencies
Projects
None yet
Milestone
5.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sharikovvladislav @shilman